Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Transport UDF plugin to apply default configurations and create wrapper codegen and test tasks #17

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Add Transport UDF plugin to apply default configurations and create wrapper codegen and test tasks #17

merged 5 commits into from
Apr 9, 2019

Conversation

shardulm94
Copy link
Contributor

@shardulm94 shardulm94 commented Apr 2, 2019 •
edited
Loading

  • Implemented Transport UDF Gradle plugin which
    • Configures default dependencies for the main and test source sets (api and test-api)
    • Applies the Transport UDF annotation processor
    • Creates SourceSets for UDF wrapper generation
    • Configures default dependencies for the platform wrapper SourceSets
    • Configures wrapper code generation tasks
    • Configures tasks to run UDF tests for the platform using the Unified Testing Framework
  • Renamed UDF properties to UDF metadata everywhere else (missed in Add generator classes to generate platform-specific wrappers #15)
  • Applied the Gradle plugin to transportable-udfs-example-udfs module
    • Verified that the tests are running using the unified testing framework & wrapper classes are generated and compiled (packaging and shading to be done in a future RB)

@shardulm94 shardulm94 self-assigned this Apr 2, 2019
@shardulm94 shardulm94 marked this pull request as ready for review April 2, 2019 20:54
@shardulm94 shardulm94 mentioned this pull request Apr 3, 2019
Closed
4 tasks
wmoustafa
wmoustafa reviewed Apr 5, 2019
View reviewed changes
...-udfs-codegen/src/test/java/com/linkedin/transport/codegen/AbstractTestWrapperGenerator.java Show resolved Hide resolved
...able-udfs-annotation-processor/src/main/java/com/linkedin/transport/processor/Constants.java Show resolved Hide resolved
transportable-udfs-examples/transportable-udfs-example-udfs/build.gradle Outdated Show resolved Hide resolved
transportable-udfs-plugin/src/main/java/com/linkedin/transport/plugin/Defaults.java Outdated Show resolved Hide resolved
transportable-udfs-plugin/src/main/java/com/linkedin/transport/plugin/Defaults.java Outdated Show resolved Hide resolved
transportable-udfs-plugin/src/main/java/com/linkedin/transport/plugin/Defaults.java Outdated Show resolved Hide resolved
transportable-udfs-plugin/src/main/java/com/linkedin/transport/plugin/Defaults.java Outdated Show resolved Hide resolved
transportable-udfs-plugin/src/main/java/com/linkedin/transport/plugin/TransportPlugin.java Outdated Show resolved Hide resolved
...able-udfs-plugin/src/main/java/com/linkedin/transport/plugin/tasks/GenerateWrappersTask.java Show resolved Hide resolved
...ble-udfs-plugin/src/main/java/com/linkedin/transport/plugin/DependencyConfigurationName.java Outdated Show resolved Hide resolved
wmoustafa
wmoustafa approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@wmoustafa wmoustafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@shardulm94 shardulm94 merged commit 89029c6 into linkedin:master Apr 9, 2019
@shardulm94 shardulm94 deleted the autogenwrappers branch April 9, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmoustafa wmoustafa wmoustafa approved these changes

Assignees

@shardulm94 shardulm94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shardulm94 @wmoustafa