New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Run Venice CI with GitHub Actions #115
[build] Run Venice CI with GitHub Actions #115
Conversation
Thanks Sushant! Is it normal that the checks show as failed? |
No, checks should not fail. |
03d18df
to
ca18d51
Compare
...-vinci-client/src/main/java/com/linkedin/davinci/ingestion/utils/IsolatedIngestionUtils.java
Show resolved
Hide resolved
15d17f9
to
61be3a7
Compare
Hi Sushant, would you mind rebasing and retrying this? Curious to see how it goes now. Thanks! |
61be3a7
to
0fb1bf6
Compare
I think we need to divide the e2e tests further. One first cut might be to do a split along the lines of:
Might need to define a couple more test targets in the Gradle build. This seems useful for that: https://mkyong.com/gradle/gradle-how-to-exclude-some-tests/ Are you game to give it a try? |
Sorry for the late response. Sure, I'll split e2e tests into two parts. They used to finish in < 3HR and hence I added 3HR timeout. But it seems we've added >25 e2e tests since then. |
@FelixGV -
Completes in 2h10m
Completes in 1h @adamxchen is planning to work on this in the next quarter. In the meantime, should we use this PR? |
Thanks a lot for the initiative Sushant!! I think we should merge this in, for sure! In the future, I would like us to reduce the wall clock time by splitting further, and/or deleting redundant tests. In any case, this is a great start! Thanks again 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tremendous 🤩🍾🙏
Thanks for the review. I'll run our internal CI once just to make sure everything else is alright. |
Run Venice tests on the following matrix: OS: macOS, ubuntu JDK: 11
To reduce build time (due to duplicate execution) remove original integration test task and keep new integrationTestA and integrationTestB tasks
c518cde
to
3cf1a9a
Compare
@FelixGV - Could you please approve the PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Please make sure to review and clean up the commit message while squashing.
Thank you @FelixGV & @nisargthakkar! |
Run Venice tests on the following matrix:
OS: macOS, Ubuntu
JDK: 11
Run Venice CI with GitHub Actions
While we figure out how we want to run CI with GitHub actions, I think it would be good to have
something up and running in the meantime. With this RB, CI will be run on every commit/pull request.
It triggers one job/OS for unit tests (~42 mins) and one for integration tests/OS (2.30 hours and a bit flaky).
How was this PR tested?
Does this PR introduce any user-facing changes?