Setting up ZKBridge repo and adding spiral KV abstractions. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrane50
force-pushed
the
add-spiral
branch
5 times, most recently
from
b3b9e05
to
a792135
Compare
parakhnr
reviewed
Apr 29, 2024
| } | ||
| } | ||
|
|
||
| public static class SpiralStoreClientBuilder { |
There was a problem hiding this comment.
You can take a look at [Immutables] to reduce some of this boiler plate.
|
|
||
| private final SpiralApiGrpc.SpiralApiBlockingStub _blockingStub; | ||
|
|
||
| private SpiralStoreClient(String spiralEndpoint, boolean useSsl, String caBundle, String identityCert, String identityKey, String overrideAuthority) { |
There was a problem hiding this comment.
Can you wrap ssl related arguments in SslConfig ?
| .build(); | ||
| GetResponse response = _blockingStub.get(request); | ||
| return response.getValue().getMessage().toByteArray(); | ||
| } catch (Exception e) { |
| * This KV-store client is used to interact with the KV-store server. | ||
| */ | ||
|
|
||
| public interface KVStoreClient<K, V, C> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up basic scaffolding for zkbridge repo. It also adds KV store abstractions for integrating spiral to zkbridge. For an overview following things are added in this PR :
Tests
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)