Create ci.yaml #102
Merged
Create ci.yaml #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating ci.yaml file to run CI for ZK ACL dev branch
micahstubbs
reviewed
Sep 7, 2022
| - name: 'full-build-cppunit-tests' | ||
| jdk: 11 | ||
| args: '-Pfull-build verify -Dtest=_ -DfailIfNoTests=false' | ||
| fail-fast: false |
There was a problem hiding this comment.
Curious, why don't we want to fail fast?
There was a problem hiding this comment.
From my understanding, zk tests are bit flaky and they mostly pass when retried. Hence we don't want to fail on first failure but try everything then re-try failed ones and then see the status for run.
mgao0
reviewed
Sep 7, 2022
rahulrane50
added a commit
to rahulrane50/zookeeper
that referenced
this pull request
Sep 9, 2022
Creating ci.yaml file to run CI for ZK ACL dev branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating ci.yaml file to run CI for ZK ACL dev branch
Description
Adding ci.yaml file from master branch to this dev branch so that every PR would go through CI tests.
Tests
Tried dispatching manual workflows on this branch.
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
NA
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)