-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ci.yaml #102
Create ci.yaml #102
Conversation
Creating ci.yaml file to run CI for ZK ACL dev branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about fail_fast
, otherwise look great. Thanks for the contribution!
- name: 'full-build-cppunit-tests' | ||
jdk: 11 | ||
args: '-Pfull-build verify -Dtest=_ -DfailIfNoTests=false' | ||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why don't we want to fail fast?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, zk tests are bit flaky and they mostly pass when retried. Hence we don't want to fail on first failure but try everything then re-try failed ones and then see the status for run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Thanks for explaining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the CI results run for this PR, there's no detailed failed tests log. Could you please check why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Creating ci.yaml file to run CI for ZK ACL dev branch
Creating ci.yaml file to run CI for ZK ACL dev branch
Description
Adding ci.yaml file from master branch to this dev branch so that every PR would go through CI tests.
Tests
Tried dispatching manual workflows on this branch.
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
NA
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)