Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: Add the ability to configure a prefix #1655

Closed
1 of 2 tasks
amitsaha opened this issue Sep 25, 2017 · 4 comments
Closed
1 of 2 tasks

prometheus: Add the ability to configure a prefix #1655

amitsaha opened this issue Sep 25, 2017 · 4 comments

Comments

@amitsaha
Copy link

Issue Type:

  • Bug report
  • Feature request

Currently, the prometheus metrics are of the form namer:xx and rt:xx and so on. Based of this discourse discussion, it would be useful to have a configurable prometheus metrics prefix. The default will still be no prefix.

@wmorgan
Copy link
Member

wmorgan commented Sep 25, 2017

@amitsaha thanks for filing this!

@amitsaha
Copy link
Author

@wmorgan happy to have been able to get my colleague to work on a PR as well :)

@wmorgan
Copy link
Member

wmorgan commented Sep 28, 2017

@amitsaha nice work!

@hawkw
Copy link
Member

hawkw commented Oct 6, 2017

Closed by #1657

@hawkw hawkw closed this as completed Oct 6, 2017
@hawkw hawkw mentioned this issue Oct 6, 2017
hawkw added a commit that referenced this issue Oct 6, 2017
## 1.3.0 2017-10-06

* **Breaking Change**: All HTTP engines are now Netty 4; `engine:` configuration key is no longer valid.
* Upgraded to Finagle 7.1
* Kubernetes
  * Added a workaround for an issue where Kubernetes namers fail to update because watches are not correctly restarted due to a regression in some versions of Kubernetes (#1636).
  * Fixed `io.l5d.k8s.configMap` interpreter failing to update after receiving an invalid dtab (#1639).
  * Performance improvements for Kubernetes namers.
* Prometheus
  * Added an optional `prefix:` configuration key to add a prefix to all metrics reported by Linkerd (#1655).
* DNS SRV Record namer
  * Ensured that DNS names in SRV queries are absolute (#1637).
  * Added an optional `domain` config key for relative DNS lookups (#1637).
  * Removed redundant `dnssrv` metrics scope from SRV record namer metrics (#1637).
* Consul
  * Consul namers no longer watch the entire list of services, improving performance significantly when there are large numbers of services (#1646).
* Curator
  * Added support for `ServiceInstance` objects with custom payloads (#1272).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants