Warn on mismatched thriftFramed settings

[siggy]

two issues:

• thriftFramed defaults to true at both router-level and server-level.
• setting thriftFramed to false at the router level does not affect server-level. I'd expect the server to honor whatever is set on the router, unless thriftFramed is explicitly set on the server to override.

[gtcampbell]

I may be able to address this as part of my configuration work - I've been doing some thinking on how we want to handle defaults there.

[gtcampbell]

Are we happy with the current state of this now that server and client are explicitly separated and there is no longer a thriftFramed setting on the router?

[klingerf]

If it's not a ton of work I think it still might be worthwhile to default thriftFramed and thriftProtocol on the client to to match whatever is set on the server. If somebody sets the server params but not the client params, then the client params should just inherit the server settings.

[adleong]

I think I disagree. If there are multiple servers, which server should the client inherit from?

Better would be some kind of config linter or warning if your client and server don't match.

[klingerf]

Fair enough, I forgot about the multiple servers case.

[gtcampbell]

I've changed the title to reflect @adleong's suggestion.

[IssueHuntBot]

@BoostIO funded this issue with $10. Visit this issue on Issuehunt