Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests for consul namer #639

Open
olix0r opened this issue Sep 8, 2016 · 1 comment
Open

integration tests for consul namer #639

olix0r opened this issue Sep 8, 2016 · 1 comment
Labels
hacktoberfest help wanted
Projects
Linkerd 1.x Backlog. See https://gith...

Comments

@olix0r
Copy link
Member

olix0r commented Sep 8, 2016

We should add integration tests (i.e under namer/consul/src/integration) that exercise end-to-end interactions with a real consul server.

Ideally:

  1. Build a consul namer from configuration yaml
  2. register services into consul
  3. exercise that naming works properly
  4. update service registration in consul
  5. ensure updates
  6. check that stats were recorded properly.
@IssueHuntBot
Copy link

@BoostIO funded this issue with $10. Visit this issue on Issuehunt

Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
@hawkw
Add response classification to proxy metrics (linkerd#639)
c688cf6 
This PR adds a `classification` label to proxy response metrics, as @olix0r described in linkerd/linkerd2#634 (comment). The label is either "success" or "failure", depending on the following rules:
+ **if** the response had a gRPC status code, *then*
   - gRPC status code 0 is considered a success
   - all others are considered failures
+ **else if** the response had an HTTP status code, *then*
  - status codes < 500 are considered success,
  - status codes >= 500 are considered failures
+ **else if** the response stream failed **then**
  - the response is a failure.

I've also added end-to-end tests for the classification of HTTP responses (with some work towards classifying gRPC responses as well). Additionally, I've updated `doc/proxy_metrics.md` to reflect the added `classification` label.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted
Projects
No open projects
Linkerd 1.x Backlog. See https://gith...
Low Priority (small)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olix0r @IssueHuntBot