Add Prometheus telemeter #938
Comments
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this issue
Dec 20, 2018
This is in preparation for landing the Tokio upgrade. In the upcoming Hyper release, the handling of absolute form request URIs moved from `hyper::Request` to the `hyper::client::connect::Connect` trait. Once we upgrade to the new Tokio, we will have to upgrade our Hyper dependency as well. Currently, Conduit detects whether the request URI is in absolute form in `h1::normalize_our_view_of_uri` and adds an extension to the request if it is. This will no longer work with the new Hyper, as that function is called from the `bind::NormalizeUri` service, which is not constructed until after the client connection is established. Therefore, it is necessary to move this information to `bind::Protocol`, so that it can be passed to `transparency::client::HyperConnect` (our implementation of Hyper's `Connect` trait) when we are using the newest Hyper. For now, however, I've left in the `UriIsAbsoluteForm` extension and continued to set it in `h1::normalize_our_view_of_uri`, since we currently still use it on the current Hyper version. I thought it was good to minimize the changes to this existing code, as it will be removed when we migrate to the new Hyper. This PR shouldn't cause any functional changes. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add a telemeter which exposes the linkerd metrics registry in prometheus format. This will serve as a replacement for the prometheus endpoint that is currently part of the core linkerd admin server. Making this a telemeter will be more modular and will also allow for more idiomatic prometheus stats because the tree structure of the MetricsTree will be available.
Depends on #934
Relates to #927
The text was updated successfully, but these errors were encountered: