Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure h2 streams are fully received before closing (#1245) #1280

Merged
merged 3 commits into from May 11, 2017
Merged

Commits on May 9, 2017

  1. Ensure h2 streams are fully received before closing (#1245)

    Problem
    
    A race condition existed that would cause a stream to be closed by the
    remote sender before the local receiver had fully received all frames in
    an h2 stream. This would result in the final frame of an h2 response
    never being sent back to the caller, causing the caller's connection to
    hang indefinitely.
    
    Solution
    
    Make the receiver fully responsible for closing streams, to ensure that
    they are fully received before closing.
    
    Validation
    
    I've deployed this branch to a test environment and it has successfully
    served gRPC traffic for the past 48 hours, whereas without this fix the
    connection would always hang within about 20 minutes.
    klingerf committed May 9, 2017
    Copy the full SHA
    07345cc View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b0f0fec View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Copy the full SHA
    58bdff3 View commit details
    Browse the repository at this point in the history