Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 1.x README to point to 2.x repo #2416

Merged
merged 4 commits into from Mar 16, 2021
Merged

update 1.x README to point to 2.x repo #2416

merged 4 commits into from Mar 16, 2021

Conversation

wmorgan
Copy link
Member

@wmorgan wmorgan commented Feb 9, 2021

Signed-off-by: William Morgan william@buoyant.io

Signed-off-by: William Morgan <william@buoyant.io>
Signed-off-by: William Morgan <william@buoyant.io>
@peterfroehlich
Copy link
Contributor

Just 5c: I don't concur with the new wording: linkerd2 is not a replacement for linkerd1.
We use nomad and aurora clusters for example, something that linkerd2 does not support with its focus on kubernetes.
I'm quite sad to see linkerd1 and namerd development stall... we are using it everywhere in our environment and are really happy with its stability and flexibility.

@wmorgan
Copy link
Member Author

wmorgan commented Feb 15, 2021

Thanks for the feedback @peterfroehlich. I also love Linkerd 1.x and am glad to hear it continues to work for you.

I'm open to suggestions for better wording. The original maintainers of 1.x are now all working on 2.x, or on other things, and the change is meant to reflect that. Leaving the page as is also doesn't feel right, as there are currently no active maintainers.

(Also, I would love to add some 1.x maintainers if you are interested in having that discussion.)

Copy link
Contributor

@peterfroehlich peterfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
HTTP/gRPC/thrift/etc proxy, and can usually be dropped into existing
applications with a minimum of configuration, regardless of what language
they're written in. It works with many common protocols and service discovery
backends, including scheduled environments like Mesos and Kubernetes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Its fully featured with powerful load balancing algorithms, failure handling, instrumentation,
distributed tracing and dynamic request routing.
It also offers a stand-alone version of the service discovery components called Namerd,
which enables a scalable architecture with centralised namers and a simple api for adaptation
to other load balancing systems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice description, just a bit of punctuation that is missing:

Linkerd is fully featured with powerful load balancing algorithms, failure handling, instrumentation, 
distributed tracing, and dynamic request routing.
It also offers a stand-alone version of the service discovery components, called Namerd, 
which enables a scalable architecture with centralised "namers" and a simple api for adaptation 
to other load balancing systems. 

@peterfroehlich
Copy link
Contributor

I'm open to suggestions for better wording. The original maintainers of 1.x are now all working on 2.x, or on other things, and the change is meant to reflect that. Leaving the page as is also doesn't feel right, as there are currently no active maintainers.

I've submitted a review, tried to move k8 user to linkerd2 without scaring away other parties.

Also, I would love to add some 1.x maintainers if you are interested in having that discussion.)

I don't have experience in that role, but my team at work has multiple Maintainers of OSS projects. I'll discuss with them and come back to you.

@cpretzer cpretzer mentioned this pull request Feb 19, 2021
wmorgan and others added 2 commits February 22, 2021 09:04
Co-authored-by: Peter Fröhlich <tarwin@tarwin.de>
Signed-off-by: William Morgan <william@buoyant.io>
@wmorgan
Copy link
Member Author

wmorgan commented Feb 22, 2021

Did a little more wordsmithing to clarify what this repo is currently used for.

@peterfroehlich
Copy link
Contributor

Thanks for including my text! ❤️

@wmorgan wmorgan merged commit 4389c8c into main Mar 16, 2021
@wmorgan wmorgan deleted the wm/update-readme branch March 16, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants