Integration test for cni-repair-controller #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
force-pushed
the
alpeb/cni-repair-controller-tests
branch
from
9fbaa2e
to
e4fb23b
Compare
(Note this will fail until linkerd/linkerd2#11699 lands) The `integration-cni-plugin.yml` workflow (formerly known as `cni-plugin-integration.yml`) has been expanded to run the new recipe `cni-repair-controller-integration`, which performs the following steps: - Rebuilds the `linkerd-cni-repair-controller` crate and `cni-plugin` - Creates a new cluster at version `v1.27.6-k3s1` (version required for Calico to work) - Triggers a new `./cni-repair-controller/integration/run.sh` script which: - Installs Calico - Installs the latest linkerd-edge CLI - Installs `linkerd-cni` and wait for it to become ready - Install the linkerd control plane in CNI mode - Install a `pause` DaemonSet The `linkerd-cni` instance has been configured to include an extra initContainer that will delay its start for 15s. Since we waited for it to become ready, this doesn't affect the initial install. But then a new node is added to the cluster, and this delay allows for the new `pause` DaemonSet replica to start before the full CNI config is ready, so we can observe its failure to come up. Once the new `linkerd-cni` replica becomes ready we observe how the `pause` failed replica is replaced by a new healthy one.
alpeb
force-pushed
the
alpeb/cni-repair-controller-tests
branch
from
e4fb23b
to
89c3415
Compare
mateiidavid
approved these changes
Jan 24, 2024
.dockerignore
Outdated
| @@ -1,2 +1 @@ | |||
| rust-toolchain | |||
| target/ | |||
There was a problem hiding this comment.
Was this change accidental? Or do we need the target dir in the context when building an image?
There was a problem hiding this comment.
Good catch. This was a leftover from an iteration where the binary wasn't build inside the same Dockerfile.
| # the full CNI config is ready and enter a failure mode | ||
| extraInitContainers: | ||
| - name: sleep | ||
| image: busybox |
There was a problem hiding this comment.
on the nitpicky side, the CNI plugin runs alpine, can we re-use the same image so we don't pull busybox in tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note this will fail until linkerd/linkerd2#11699 lands)
The
integration-cni-plugin.ymlworkflow (formerly known ascni-plugin-integration.yml) has been expanded to run the new recipecni-repair-controller-integration, which performs the following steps:linkerd-cni-repair-controllercrate andcni-pluginv1.27.6-k3s1(version required for Calico to work)./cni-repair-controller/integration/run.shscript which:linkerd-cniand wait for it to become readypauseDaemonSetThe
linkerd-cniinstance has been configured to include an extra initContainer that will delay its start for 15s. Since we waited for it to become ready, this doesn't affect the initial install. But then a new node is added to the cluster, and this delay allows for the newpauseDaemonSet replica to start before the full CNI config is ready, so we can observe its failure to come up. Once the newlinkerd-cnireplica becomes ready we observe how thepausefailed replica is replaced by a new healthy one.