Fix inotify dependency #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since my PR against inotify (hannobraun/inotify-rs#124) has merged, we can go back to depending on the upstream version. Also, this updates the SHA we depend on to one that actually exists. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
AFAICT the main proxy crate's inotify dependency is not actually used, as the `fs-watch` lib crate fully encapsulates the dependency. I think that this was overlooked when factoring out `fs-watch` into its own crate. It seems better to not specify the same dependency in multiple places, especially since we're not using one of them... Signed-off-by: Eliza Weisman <eliza@buoyant.io>
olix0r
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my PR against
inotify(hannobraun/inotify-rs#124) has merged, we cango back to depending on the upstream version. Also, this updates the SHA
we depend on to one that actually exists, which should fix the build.
I've also removed the
inotifydependency from the main proxy crate'sCargo.toml.This dependency is not actually used, as thefs-watchlibcrate fully encapsulates the dependency. I think that this was overlooked
when factoring out
fs-watchinto its own crate.It seems better to not specify the same dependency in multiple places,
especially since we're not using one of them.
Signed-off-by: Eliza Weisman eliza@buoyant.io