outbound: Log and remove l5d-proxy-error from responses #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an outbound client reads a response from a remote peer that includes the l5d-proxy-error header, it doesn't communicate this error state in logs, and it (incorrectly, according to the comments) leaves the l5d-proxy-error header on the response. Furthermore, we currently _always_ emit a DEBUG log message "Remote proxy error", even when no error header is present. This change updates the error handler to: 1. Emit 'Remote proxy error' messages at INFO level when the header is validly set; 2. Strip these headers when they are logged (i.e. to eliminate ambiguity and potential for double-logging). Tests are updated to exercise the header removal logic.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
- Coverage 67.66% 67.64% -0.02%
==========================================
Files 332 332
Lines 15152 15149 -3
==========================================
- Hits 10252 10247 -5
- Misses 4900 4902 +2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 16, 2024
--- * build(deps): bump rcgen from 0.11.3 to 0.12.0 (linkerd/linkerd2-proxy#2677) * build(deps): bump jobserver from 0.1.26 to 0.1.27 (linkerd/linkerd2-proxy#2679) * build(deps): bump bumpalo from 3.12.0 to 3.14.0 (linkerd/linkerd2-proxy#2678) * outbound: Log and remove l5d-proxy-error from responses (linkerd/linkerd2-proxy#2694) * http: Parameterize NewServeHttp (linkerd/linkerd2-proxy#2696) * gateway: Avoid double http prefixing in metric names (linkerd/linkerd2-proxy#2701) Signed-off-by: Oliver Gould <ver@buoyant.io>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 19, 2024
--- * build(deps): bump rcgen from 0.11.3 to 0.12.0 (linkerd/linkerd2-proxy#2677) * build(deps): bump jobserver from 0.1.26 to 0.1.27 (linkerd/linkerd2-proxy#2679) * build(deps): bump bumpalo from 3.12.0 to 3.14.0 (linkerd/linkerd2-proxy#2678) * outbound: Log and remove l5d-proxy-error from responses (linkerd/linkerd2-proxy#2694) * http: Parameterize NewServeHttp (linkerd/linkerd2-proxy#2696) * gateway: Avoid double http prefixing in metric names (linkerd/linkerd2-proxy#2701) Signed-off-by: Oliver Gould <ver@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an outbound client reads a response from a remote peer that includes the l5d-proxy-error header, it doesn't communicate this error state in logs, and it (incorrectly, according to the comments) leaves the l5d-proxy-error header on the response.
Furthermore, we currently always emit a DEBUG log message "Remote proxy error", even when no error header is present.
This change updates the error handler to:
Tests are updated to exercise the header removal logic.