resolve: Do not send the 'k8s' scheme #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that the proxy sends resolve requests with a scheme value of `k8s` is an accident of history. Given that this value is currently unused by the controller, stop setting a scheme value entirely.
olix0r
requested review from
hawkw,
kleimkuhler and
adleong
and removed request for
hawkw and
kleimkuhler
kleimkuhler
approved these changes
Sep 18, 2019
|
@kleimkuhler the "scheme" in tap should come from the http metadata -- if that's missing that sounds like a bug. this scheme is like that, but not the same thing, really. we don't really have a use for the field at the moment, but we may want to start hydrating it i.e. "http", "https", "tcp", "tls", etc based on the context of the resolution (i.e. the http router vs the tcp forwarder, etc). |
hawkw
approved these changes
Sep 18, 2019
|
@olix0r Okay thanks. I will look into it more |
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Sep 18, 2019
This change updates the internals of the proxy's client to the Destination controller. Other than some minor fixes to the client's backoff logic, no user-facing changes are expected. * Split service discovery into composable components (linkerd/linkerd2-proxy#341) * logging: update `tracing` and `tracing-subscriber` (linkerd/linkerd2-proxy#352) * resolve: Do not send the 'k8s' scheme (linkerd/linkerd2-proxy#356)
alpeb
pushed a commit
to linkerd/linkerd2
that referenced
this pull request
Sep 18, 2019
This change updates the internals of the proxy's client to the Destination controller. Other than some minor fixes to the client's backoff logic, no user-facing changes are expected. * Split service discovery into composable components (linkerd/linkerd2-proxy#341) * logging: update `tracing` and `tracing-subscriber` (linkerd/linkerd2-proxy#352) * resolve: Do not send the 'k8s' scheme (linkerd/linkerd2-proxy#356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that the proxy sends resolve requests with a scheme value of
k8sis an accident of history. Given that this value is currentlyunused by the controller, stop setting a scheme value entirely.