Avoid buffering control plane discovery #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discovery layer handles both building a service for each discovered endpoint, as well as a buffer that fails when the service is not polled (i.e. because it has been leaked somehow). This coupling doesn't match other use cases though when, for instance, the client may not be used frequently, as is the case for proxy-to-control-plane communication. This change decouples these layers so that the buffering is decoupled from endpoint-service construction.
The discovery layer handles both building a service for each discovered endpoint, as well as a buffer that fails when the service is not polled (i.e. because it has been leaked somehow). This coupling doesn't match other use cases though when, for instance, the client may not be used frequently, as is the case for proxy-to-control-plane communication. This change decouples these layers so that the buffering is decoupled from endpoint-service construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates #631 to avoid the watchdog/buffer on control plane discovery.