Skip to content

Commit

Permalink
Set mutating webhook rules scope to Namespaced
Browse files Browse the repository at this point in the history
Subject: Setting the scope for mutating webhooks rules

Problem: The linkerd-proxy-injector-webhook-config, linkerd-jaeger-injector-webhook-config, and linkerd-tap-injector-webhook-config mutating webhooks raise a warning on GKE that says "Update webhook to no longer intercept system requests." in the GCP console recommendation section.

Solution: Setting the scope to Namespaced for both webhooks

Validation: This should not change the webhooks behaviour as all webhooks are triggered only by pod/service creation requests, and pods/services are namespaced resources.

Fixes #12193

Signed-off-by: f.medini <f.medini@nyris.io>
  • Loading branch information
mdnfiras committed Mar 25, 2024
1 parent 6eeaea4 commit 44e6544
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,6 @@ webhooks:
apiGroups: [""]
apiVersions: ["v1"]
resources: ["pods", "services"]
scope: "Namespaced"
sideEffects: None
timeoutSeconds: {{ .Values.proxyInjector.timeoutSeconds | default 10 }}
1 change: 1 addition & 0 deletions jaeger/charts/linkerd-jaeger/templates/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ webhooks:
apiGroups: [""]
apiVersions: ["v1"]
resources: ["pods"]
scope: "Namespaced"
sideEffects: None
{{ if .Values.jaeger.enabled -}}
---
Expand Down
1 change: 1 addition & 0 deletions viz/charts/linkerd-viz/templates/tap-injector-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,5 @@ webhooks:
apiGroups: [""]
apiVersions: ["v1"]
resources: ["pods"]
scope: "Namespaced"
sideEffects: None

0 comments on commit 44e6544

Please sign in to comment.