Skip to content

Commit

Permalink
chore: fix function name in comment (#12396)
Browse files Browse the repository at this point in the history
Fixed comments for `subscribeToServicesWithContext` and `reconcileByAddressType`. Previously,
the comments contained incorrect function names.

Signed-off-by: hanghuge <cmoman@outlook.com>
  • Loading branch information
hanghuge committed Apr 10, 2024
1 parent 3574a2c commit 78d42b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (r *endpointsReconciler) reconcile(svc *corev1.Service, ews []*ewv1beta1.Ex
return utilerrors.NewAggregate(errs)
}

// reconcileIPv4Endpoints operates on a set of external workloads, their
// reconcileByAddressType operates on a set of external workloads, their
// service, and any endpointslices that have been created by the controller. It
// will compute the diff that needs to be written to the API Server.
func (r *endpointsReconciler) reconcileByAddressType(svc *corev1.Service, extWorkloads []*ewv1beta1.ExternalWorkload, existingSlices []*discoveryv1.EndpointSlice, addrType discoveryv1.AddressType) error {
Expand Down
2 changes: 1 addition & 1 deletion controller/api/destination/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ func (s *server) subscribeToServiceProfile(
return s.subscribeToServicesWithContext(fqn, token, listener, canceled, log, streamEnd)
}

// subscribeToServiceWithContext establishes two profile watches: a "backup"
// subscribeToServicesWithContext establishes two profile watches: a "backup"
// watch (ignoring the client namespace) and a preferred "primary" watch
// assuming the client's context. Once updates are received for both watches, we
// select over both watches to send profile updates to the stream. A nil update
Expand Down

0 comments on commit 78d42b2

Please sign in to comment.