Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm linkerd-controler-plane Allow Custom labels on Pod Monitor #11175

Closed
jseiser opened this issue Jul 27, 2023 · 1 comment · Fixed by #11222 or #11409
Closed

Helm linkerd-controler-plane Allow Custom labels on Pod Monitor #11175

jseiser opened this issue Jul 27, 2023 · 1 comment · Fixed by #11222 or #11409

Comments

@jseiser
Copy link
Contributor

jseiser commented Jul 27, 2023

What problem are you trying to solve?

I need the prometheus operator to be able to scrape our pod monitors that we create from this helm chart.

How should the problem be solved?

https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/README.md#prometheusioscrape

We just need to label the podMonitor

Any alternatives you've considered?

I could modify the default scraping of the Prometheus operator

How would users interact with this feature?

No response

Would you like to work on this feature?

yes

@alpeb
Copy link
Member

alpeb commented Aug 3, 2023

Sounds like a simple addition into the podmonitor.yaml template. Please submit a PR and I'd be happy to review it :-)

mateiidavid added a commit that referenced this issue Sep 22, 2023
This edge release updates the proxy's dependency on the `rustls` library to
patch security vulnerability [RUSTSEC-2023-0052]  (GHSA-8qv2-5vq6-g2g7), a
potential CPU usage denial-of-service attack when acceting a TLS handshake from
an untrusted peer with a maliciously-crafted certificate. Furthermore, this
edge release contains a few improvements to the control plane and jaeger
extension Helm charts.

* Addressed security vulnerability [RUSTSEC-2023-0052] in the proxy by updating
  its dependency on the `rustls` library
* Added a `prometheusUrl` field for the heartbeat job in the control plane Helm
  chart (thanks @david972!) ([#11343]; fixes [#11342])
* Introduced support for arbitrary labels in the `podMonitors` field in the
  control plane Helm chart (thanks @jseiser!) ([#11222]; fixes [#11175])
* Added support for config merge and Deployment environment to
  `opentelemetry-collector` in the jaeger extension (thanks @iAnomaly!)
  ([#11283])

[#11283]: #11283
[#11222]: #11222
[#11175]: #11175
[#11343]: #11343
[#11342]: #11342

Signed-off-by: Matei David <matei@buoyant.io>
mateiidavid added a commit that referenced this issue Sep 22, 2023
* edge-29.9.3

This edge release updates the proxy's dependency on the `rustls` library to
patch security vulnerability [RUSTSEC-2023-0052]  (GHSA-8qv2-5vq6-g2g7), a
potential CPU usage denial-of-service attack when acceting a TLS handshake from
an untrusted peer with a maliciously-crafted certificate. Furthermore, this
edge release contains a few improvements to the control plane and jaeger
extension Helm charts.

* Addressed security vulnerability [RUSTSEC-2023-0052] in the proxy by updating
  its dependency on the `rustls` library
* Added a `prometheusUrl` field for the heartbeat job in the control plane Helm
  chart (thanks @david972!) ([#11343]; fixes [#11342])
* Introduced support for arbitrary labels in the `podMonitors` field in the
  control plane Helm chart (thanks @jseiser!) ([#11222]; fixes [#11175])
* Added support for config merge and Deployment environment to
  `opentelemetry-collector` in the jaeger extension (thanks @iAnomaly!)
  ([#11283])

[#11283]: #11283
[#11222]: #11222
[#11175]: #11175
[#11343]: #11343
[#11342]: #11342

Signed-off-by: Matei David <matei@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants