Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running go vet ./... in CI #125

Closed
klingerf opened this issue Jan 9, 2018 · 0 comments · Fixed by #128
Closed

Start running go vet ./... in CI #125

klingerf opened this issue Jan 9, 2018 · 0 comments · Fixed by #128
Assignees

Comments

@klingerf
Copy link
Member

klingerf commented Jan 9, 2018

We can use go vet to detect go code issues that are not caught by the compiler. If we add this to CI, then it should prevent regressions going forward. We'll also need to fix these issues as part of that branch:

$ go vet ./...
pkg/k8s/kubectl.go:88: arg kctl.ProxyPort in printf call is a function value, not a function call
pkg/k8s/kubectl_test.go:80: arg kctl.ProxyPort in printf call is a function value, not a function call
pkg/k8s/kubectl_test.go:108: arg kctl.ProxyPort in printf call is a function value, not a function call
exit status 1
pkg/shell/shell_test.go:103: arg output for printf verb %s of wrong type: *bufio.Reader
exit status 1
proxy-init/integration_test/iptables/http_test.go:198: arg resp for printf verb %s of wrong type: *net/http.Response
exit status 1
proxy-init/integration_test/iptables/test_service/test_service.go:50: arg amITheProxy for printf verb %s of wrong type: bool
exit status 1
web/main.go:67: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
web/main.go:41: arg kubernetesApiHost for printf verb %s of wrong type: *string
web/main.go:45: arg kubernetesApiHost for printf verb %s of wrong type: *string
exit status 1
@dadjeibaah dadjeibaah self-assigned this Jan 9, 2018
@dadjeibaah dadjeibaah added the review/ready Issue has a reviewable PR label Jan 9, 2018
@dadjeibaah dadjeibaah removed the review/ready Issue has a reviewable PR label Jan 9, 2018
khappucino pushed a commit to Nordstrom/linkerd2 that referenced this issue Mar 5, 2019
The `linkerd2_stack::Either` type is used to implement Layer, Stack, and
Service for alternate underlying implementations. However, the Service
implementation requires that both inner services emit the same type of
Error.

In order to allow the underlying types to emit different errors, this
change uses `Either` to wrap the underlying errors, and implements
`Error` for `Either`.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants