Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkerd check output is >80 characters for [retry] and [fail] lines #1653

Closed
wmorgan opened this issue Sep 14, 2018 · 1 comment
Closed

linkerd check output is >80 characters for [retry] and [fail] lines #1653

wmorgan opened this issue Sep 14, 2018 · 1 comment
Assignees
@siggy
Labels
area/cli help wanted
Projects
Diagnostics Polish Post 2.1 Polish

Comments

@wmorgan
Copy link
Member

wmorgan commented Sep 14, 2018

It would be nice for everything to fit in an 80-column window, and there's no reason for it not to right now other than a few extra "."'s.
@rmars rmars added this to Triage in Diagnostics Polish Sep 18, 2018
@wmorgan wmorgan mentioned this issue Sep 18, 2018
Closed
@klingerf klingerf added this to To do in Post 2.1 Polish via automation Nov 29, 2018
@siggy siggy moved this from To do to Ready in Post 2.1 Polish Jan 9, 2019
@siggy siggy self-assigned this Jan 9, 2019
siggy added a commit that referenced this issue Jan 15, 2019
@siggy
Update check and inject output
846e153 
Reorganize output of check and inject commands, to provide more info
when errors occur, and less output when successful. Also add emojis and
spinners.

Fixes #1471, #1653, #1656, #1739

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Jan 15, 2019
@siggy
Update check and inject output
4f042de 
The outputs of the `check` and inject commands did not vary much between
successful and failed executions, and were a bit verbose and visually
challenging to parse.

Reorganize output of check and inject commands, to provide more info
when errors occur, and less output when successful. Specific changes:

`linkerd check`
- visually group checks by category
- introduce `hintURL`'s, to provide doc links when checks fail
- add spinners when retrying, remove addtional retry lines
- colored emojis to indicate success/warning/failure

`linkerd inject`
- modify default output to mirror `kubectl apply`
- only output non-successful inject reports
- support `--verbose` flag to output all inject reports

Fixes #1471, #1653, #1656, #1739

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Jan 15, 2019
@siggy
Update check and inject output
45edfda 
The outputs of the `check` and inject commands did not vary much between
successful and failed executions, and were a bit verbose and visually
challenging to parse.

Reorganize output of check and inject commands, to provide more info
when errors occur, and less output when successful. Specific changes:

`linkerd check`
- visually group checks by category
- introduce `hintURL`'s, to provide doc links when checks fail
- add spinners when retrying, remove addtional retry lines
- colored emojis to indicate success/warning/failure

`linkerd inject`
- modify default output to mirror `kubectl apply`
- only output non-successful inject reports
- support `--verbose` flag to output all inject reports

Fixes #1471, #1653, #1656, #1739

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Jan 15, 2019
@siggy
Update check and inject output
75971c4 
The outputs of the `check` and `inject` commands did not vary much
between successful and failed executions, and were a bit verbose and
challenging to parse.

Reorganize output of `check` and `inject` commands, to provide more
output when errors occur, and less output when successful.

Specific changes:

`linkerd check`
- visually group checks by category
- introduce `hintURL`'s, to provide doc links when checks fail
- add spinners when retrying, remove addtional retry lines
- colored emojis to indicate success/warning/failure

`linkerd inject`
- modify default output to mirror `kubectl apply`
- only output non-successful inject reports
- support `--verbose` flag to output all inject reports

Fixes #1471, #1653, #1656, #1739

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy mentioned this issue Jan 15, 2019
Merged
@siggy siggy moved this from Ready to Needs review in Post 2.1 Polish Jan 15, 2019
siggy added a commit that referenced this issue Jan 16, 2019
@siggy
Update check and inject output
5bae429 
The outputs of the `check` and `inject` commands did not vary much
between successful and failed executions, and were a bit verbose and
challenging to parse.

Reorganize output of `check` and `inject` commands, to provide more
output when errors occur, and less output when successful.

Specific changes:

`linkerd check`
- visually group checks by category
- introduce `hintURL`'s, to provide doc links when checks fail
- add spinners when retrying, remove addtional retry lines
- colored emojis to indicate success/warning/failure

`linkerd inject`
- modify default output to mirror `kubectl apply`
- only output non-successful inject reports
- support `--verbose` flag to output all inject reports

Fixes #1471, #1653, #1656, #1739

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Jan 16, 2019
@siggy
Update check and inject output (#2087)
92f2cd9 
The outputs of the `check` and `inject` commands did not vary much
between successful and failed executions, and were a bit verbose and
challenging to parse.

Reorganize output of `check` and `inject` commands, to provide more
output when errors occur, and less output when successful.

Specific changes:

`linkerd check`
- visually group checks by category
- introduce `hintURL`'s, to provide doc links when checks fail
- add spinners when retrying, remove additional retry lines
- colored unicode characters to indicate success/warning/failure

`linkerd inject`
- modify default output to mirror `kubectl apply`
- only output non-successful inject reports
- support `--verbose` flag to output all inject reports

Fixes #1471, #1653, #1656, #1739

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy
Copy link
Member

siggy commented Jan 16, 2019

Fixed via #2087.

@siggy siggy closed this as completed Jan 16, 2019
Post 2.1 Polish automation moved this from Needs review to Done Jan 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siggy siggy

Labels
area/cli help wanted
Projects
No open projects
Diagnostics Polish
  
Triage
Post 2.1 Polish
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmorgan @siggy