Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy tests should have all settings configuration go through the normal settings parser #28

Closed
briansmith opened this issue Dec 8, 2017 · 3 comments
Closed

Proxy tests should have all settings configuration go through the normal settings parser #28

briansmith opened this issue Dec 8, 2017 · 3 comments
Labels
area/proxy wontfix

Comments

@briansmith
Copy link
Contributor

briansmith commented Dec 8, 2017 •
edited
Loading

In proxy/tests/support/proxy.rs we have:

    // TODO: We currently can't use `config::ENV_METRICS_FLUSH_INTERVAL_SECS`
    // because we need to be able to set the flush interval to a fraction of a
    // second. We should change config::ENV_METRICS_FLUSH_INTERVAL_SECS so that
    // it can support this.

This issue is about addressing that TODO. I suggest we implement #27 and then set the flush interval to whatever number of milliseconds is needed in the test harness.
@stale
Copy link

stale bot commented Oct 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 7, 2018
@hawkw
Copy link
Member

hawkw commented Oct 8, 2018

I believe this may have already been fixed by #909?

@stale stale bot removed the wontfix label Oct 8, 2018
@stale
Copy link

stale bot commented Jan 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 6, 2019
@stale stale bot closed this as completed Jan 20, 2019
khappucino pushed a commit to Nordstrom/linkerd2 that referenced this issue Mar 5, 2019
@briansmith
Add initial tests for client and server connection handling w.r.t. TL…
9a19457 
…S. (linkerd#28)

* Add initial tests for client and server connection handling w.r.t. TLS.

Add a simple framework for TLS connection handling and some initial tests
that use it.

An explicit effort has been made to keep the test configuration as close to the
production configuration as possible; e.g. we use regular TCP sockets instead of some
mock TCP sockets. This matters less now, but will matter more later, if/when we
implement more low-level TLS-over-TCP optimizations.

Rename `ConnectionConfig::identity` to `ConnectionConfig::server_identity` to make
it clearer that it is always the identity of the server, regardless of which role
the `ConnectionConfig` is being used in.

Signed-off-by: Brian Smith <brian@briansmith.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/proxy wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briansmith @hawkw