-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade using --from-manifest option causes APIService error #3559
Labels
Projects
Comments
I believe the reason why some users encountered this error is because the doc instructed them to dump the entire control plane YAML into the manifest file:
From the same doc, this probably makes more sense, and probably won't trigger the error:
|
siggy
added a commit
that referenced
this issue
Oct 14, 2019
The `linkerd upgrade --from-manifests` command supports reading the manifest output via `linkerd install`. PR #3167 introduced a tap APIService object into `linkerd install`, but the manifest-reading code in fake.go was never updated to support this new object kind. Update the fake clientset code to support APIService objects. Fixes #3559 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy
added a commit
that referenced
this issue
Oct 16, 2019
The `linkerd upgrade --from-manifests` command supports reading the manifest output via `linkerd install`. PR #3167 introduced a tap APIService object into `linkerd install`, but the manifest-reading code in fake.go was never updated to support this new object kind. Update the fake clientset code to support APIService objects. Fixes #3559 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy
added a commit
that referenced
this issue
Oct 21, 2019
The `linkerd upgrade --from-manifests` command supports reading the manifest output via `linkerd install`. PR #3167 introduced a tap APIService object into `linkerd install`, but the manifest-reading code in fake.go was never updated to support this new object kind. Update the fake clientset code to support APIService objects. Fixes #3559 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
ihcsim
pushed a commit
that referenced
this issue
Oct 21, 2019
The `linkerd upgrade --from-manifests` command supports reading the manifest output via `linkerd install`. PR #3167 introduced a tap APIService object into `linkerd install`, but the manifest-reading code in fake.go was never updated to support this new object kind. Update the fake clientset code to support APIService objects. Fixes #3559 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When upgrade is performed with the
--from-manifest
option, the command failed with the following error:It looks like theapiextensions
client lib needs to be updated fromv1beta1
tov1
. When I attempted to fix this, go mod upgraded other k8s serializer-related packages, which are depended upon bycontroller/gen/client/clientset/versioned/typed/serviceprofile
package.It looks like the decoder doesn't have the scheme to decode
apiregistration.k8s.io/v1/APIService
.The workaround is to use the
linkerd upgrade
command. The only difference is that--from-manifest
reads the Linkerd config from a static file, instead of the k8s API.The text was updated successfully, but these errors were encountered: