Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit inject configures the proxy to log way too much detail #57

Closed
briansmith opened this issue Dec 16, 2017 · 0 comments
Closed

conduit inject configures the proxy to log way too much detail #57

briansmith opened this issue Dec 16, 2017 · 0 comments
Labels

Comments

@briansmith
Copy link
Contributor

Currently there's a lot of output for kubectl logs "-lconduit.io/plane=data" -c conduit-proxy because conduit inject configures the proxy with CONDUIT_PROXY_LOG=trace,h2=debug,mio=info,tokio_core=info. I found it to be overwhelming when debugging a configuration error.

I think a better default would be CONDUIT_PROXY_LOG=warn,conduit_proxy=info but I'm not sure of all the thinking that's gone into the current choice.

/cc @adleong

briansmith added a commit that referenced this issue Dec 16, 2017
Previously `conduit inject` was configuring the proxy to log a lot of
detail, most of which is probably shouldn't be relevant to Conduit
users.

Configure the proxy to log at the "info" level instead for the proxy
itself, and the "warn" level for internal components of the proxy.

Validated by manually doing a `conduit inject`, triggering some
traffic, and inspecting the logs.

Fixes #57
briansmith added a commit that referenced this issue Dec 18, 2017
Previously `conduit inject` was configuring the proxy to log a lot of
detail, most of which is probably shouldn't be relevant to Conduit
users.

Configure the proxy to log at the "info" level instead for the proxy
itself, and the "warn" level for internal components of the proxy.

Validated by manually doing a `conduit inject`, triggering some
traffic, and inspecting the logs.

Fixes #57
khappucino pushed a commit to Nordstrom/linkerd2 that referenced this issue Mar 5, 2019
Various transport-specific labels are defined in the common
`metrics::labels` module.

In preparation to refactor transport metrics into Sensor and Report
halves, this change moves all transport-specific labels into the
transport metrics module.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant