edge-23.4.2 #10794
Merged
edge-23.4.2 #10794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
reviewed
Apr 20, 2023
CHANGES.md
Outdated
| * Added --set flag to install-cni plugin | ||
|
|
||
| * Control Plane | ||
| * Add `trust_dns=error` to default proxy log level |
There was a problem hiding this comment.
This is not really a "control plane" change, it changes a default configuration variable for the proxy. I wouldn't put it under a "control plane" bullet point.
alpeb
reviewed
Apr 20, 2023
alpeb
reviewed
Apr 20, 2023
alpeb
reviewed
Apr 20, 2023
Credit Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io>
alpeb
reviewed
Apr 20, 2023
CHANGES.md
Outdated
| * Added --set flag to install-cni plugin | ||
|
|
||
| * Control Plane | ||
| * Add `trust_dns=error` to default proxy log level |
There was a problem hiding this comment.
Can you also add the user-facing consequence? This silences warnings in the proxy logs (so this belongs under the proxy heading IMO) from that module, that are generally spurious.
Credit Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io>
|
Please add under the Viz section: |
alpeb
reviewed
Apr 20, 2023
alpeb
reviewed
Apr 20, 2023
Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io>
alpeb
reviewed
Apr 20, 2023
Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: David McLaughlin <david@dmclaughlin.com>
hawkw
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.