Fix service mirror controller warnings for remote-discover services #11251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adleong
reviewed
Aug 15, 2023
| @@ -894,6 +894,10 @@ func (rcsw *RemoteClusterServiceWatcher) Start(ctx context.Context) error { | |||
| rcsw.log.Debugf("skipped processing endpoints object %s/%s: missing %s label", epNew.Namespace, epNew.Name, consts.DefaultExportedServiceSelector) | |||
| return | |||
| } | |||
| if rcsw.isRemoteDiscovery(epNew.Labels) { | |||
There was a problem hiding this comment.
Do the endpoints of an exported service have the exported label on them? Typically, the user would only label the exported service. Does the endpoints controller copy this label to the endpoints or something like that?
There was a problem hiding this comment.
Yup, it appears labels are copied into the endpoints automatically:
$ k -n emojivoto expose pod web-8559b97f7c-pk6xq --port 80
service/web-8559b97f7c-pk6xq exposed
$ k -n emojivoto label svc/web-8559b97f7c-pk6xq mirror.linkerd.io/exported=remote-discovery
$ k -n emojivoto get ep web-8559b97f7c-pk6xq -ojson | jq .metadata.labels
{
"app": "web-svc",
"linkerd.io/control-plane-ns": "linkerd",
"linkerd.io/proxy-deployment": "web",
"linkerd.io/workload-ns": "emojivoto",
"mirror.linkerd.io/exported": "remote-discovery",
"pod-template-hash": "8559b97f7c",
"version": "v11"
}
Warnings were getting generated in the service mirror controller during repairEndpoints and when reacting to Endpoints updates on the target cluster. Fixed that, while refactored the `isRemoteDiscovery` function to be more generic.
alpeb
force-pushed
the
alpeb/remove-remote-disco-warnings
branch
from
9be6686
to
c99c550
Compare
adleong
approved these changes
Aug 15, 2023
olix0r
approved these changes
Aug 16, 2023
alpeb
added a commit
that referenced
this pull request
Aug 16, 2023
This is a release candidate for stable-2.14.0; we encourage you to help trying it out! This edge release contains a number of improvements over the multi-cluster features introduced in the last edge release supporting flat networks. It also hardens the containers security stance by removing write access to the root filesystem. * Enhanced `linkerd multicluster link` to allow clusters to be linked without a gateway ([#11226]) * Added cluster store size gauge metric ([#11256]) * Disabled local traffic policy for remote discovery ([#11257]) * Fixed various innocuous multi-cluster warnings ([#11251], [#11246], [#11253]) * Set `readOnlyRootFilesystem: true` in all the containers, as they don't require write permissions ([#11221]; fixes [#11142]) (thanks @mikutas!)
alpeb
added a commit
that referenced
this pull request
Aug 16, 2023
This is a release candidate for stable-2.14.0; we encourage you to help trying it out! This edge release contains a number of improvements over the multi-cluster features introduced in the last edge release supporting flat networks. It also hardens the containers security stance by removing write access to the root filesystem. * Enhanced `linkerd multicluster link` to allow clusters to be linked without a gateway ([#11226]) * Added cluster store size gauge metric ([#11256]) * Disabled local traffic policy for remote discovery ([#11257]) * Fixed various innocuous multi-cluster warnings ([#11251], [#11246], [#11253]) * Set `readOnlyRootFilesystem: true` in all the containers, as they don't require write permissions ([#11221]; fixes [#11142]) (thanks @mikutas!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings were getting generated in the service mirror controller during repairEndpoints and when reacting to Endpoints updates on the target cluster. Fixed that, while refactored the
isRemoteDiscoveryfunction to be more generic.