Fix kind in policy status index delete #11471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
mateiidavid
approved these changes
Oct 10, 2023
hawkw
approved these changes
Oct 10, 2023
alpeb
added a commit
that referenced
this pull request
Oct 12, 2023
This edge release includes a fix addressing an issue during upgrades for instances not relying on automated webhook certificate management (like cert-manager provides). * Added a `checksum/config` annotation to the destination and proxy injector deployment manifests to force restarting those workloads whenever their webhook secrets change during upgrade (thanks @iAnomaly!) ([#11440]) * Fixed policy controller error when deleting a gateway API HTTPRoute resource ([#11471])
alpeb
added a commit
that referenced
this pull request
Oct 12, 2023
## edge-23.10.2 This edge release includes a fix addressing an issue during upgrades for instances not relying on automated webhook certificate management (like cert-manager provides). * Added a `checksum/config` annotation to the destination and proxy injector deployment manifests, to force restarting those workloads whenever their webhook secrets change during upgrade (thanks @iAnomaly!) ([#11440]) * Fixed policy controller error when deleting a Gateway API HTTPRoute resource ([#11471]) [#11440]: #11440 [#11471]: #11471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the policy controller's status index detects the deletion of a gateway API HTTPRoute, it attempts to delete that resource out of its own index. However, we use the wrong kind in the key when deleting. This results in the resource persisting in the index after it has been deleted from the cluster, which causes an error to be logged every 10 seconds when the policy controller attempts to do reconciliation and ensure that the statuses of all HTTPRoutes in its index are correct:
To fix this, we use the correct kind when deleting from the index.