Introduce configurable values for protocol detection

[mateiidavid]

Introduce configurable values for protocol detection

This change allows users to configure protocol detection timeout values
(outbound and inbound). Certain environments may find that protocol
detection inhibits debugging and makes it harder to reason with a
client's behaviour. In such cases (and not only) it may be deseriable to
change the default protocol detection timeout to a higher value than the
default 10s.

Through this change, users may configure their timeout values either
with install-time settings or through annotations; this follows our
usual proxy configuration model. The proxy uses different timeout values
for the inbound and outbound stacks (even though they use the same
default value) and this change respects that by adding two separate
fields.

Signed-off-by: Matei David matei@buoyant.io

[adleong]

Giving users the opportunity to configure this timeout may encourage users to try tweaking this value, especially if they are reacting to seeing protocol detection timeouts. This may lead to a frustrating experience since there isn't really a "right" value for this timeout and changing it is unlikely to do what users want or expect.

What do you think, instead, of having this be a boolean helm value inboundDisableProtocolDetectionTimeout or something along those lines which simply sets the proxy's inbound protocol detection timeout to some absurdly high value (years? max_value? something like that). This should have the same effect but be less confusing.

[alpeb]

LGTM modulo the unit test fixes 👍