Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove k8sAPI/metadataAPI dependency from endpointProfileTranslator #11587

Merged
merged 1 commit into from Nov 14, 2023

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Nov 7, 2023

This removes endpointProfileTranslator's dependency on the k8sAPI and metadataAPI, which are not used. This was introduced in one of #11334's refactorings, but ended up being not required. No functional changes here.

This removes `endpointProfileTranslator`'s dependency on the k8sAPI and
metadataAPI, which are not used. This was introduced in one of #11334's
refactorings, but ended up being not required. No functional changes
here.
@alpeb alpeb requested a review from a team as a code owner November 7, 2023 22:16
Copy link
Member

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I haven't tested everything works. My assumption is that if those were used we'd bump into compile time issues anyway so it seems safe to take them out 👍🏻

@alpeb alpeb merged commit c7db3b3 into main Nov 14, 2023
34 checks passed
@alpeb alpeb deleted the alpeb/ep-profile-translator-no-meta branch November 14, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants