Added an option to disable namespace-metadata

[shinigami-777]

Fixes #11585
Added option in values.yaml in extensions charts to disable the namspace-metadata jobs for helm based installations.
The createNamespaceMetadataJob flag should be set to false from cli to disable it. Disable if lack of privileges require doing it manually.

[shinigami-777]

Providing namespace-metadata disable option #11585

[alpeb]

Hi @shinigami-777 , thanks for the contribution. Please add a comment to this PR describing your change, and a reference to the issue it fixes. Also make sure you test your change before submitting, to validate it addresses the issue.

[alpeb]

I've added a suggestion for a different naming of this new setting. After applying that, please run ./bin/helm-docs to regenerate the helm values documentation in the charts README.md files.

[alpeb]

Suggested change

	# -- adding an option to disble namespace-metadata jobs
	skipNamespaceMetadataJobs: false
	# -- Creates a Job that adds necessary metadata to the extension's namespace
	# during install; disable if lack of privileges require doing this manually
	createNamespaceMetadataJobs: true

[shinigami-777]

Thanks for the suggestion @alpeb .I have made the suggested changes and regenerated the helm values documentation in the charts README.md files.

[alpeb]

Thanks @shinigami-777 , this looks good to me. I'd like however to amend my previous comment on naming: can you rename the setting createNamespaceMetadataJob, given that it's just one job (per extension)? Sorry for the nit picking!

[alpeb]

You require spaces here or else the template breaks, as you can see in the integration tests results.

Suggested change

	{{-end}}
	{{- end }}

[shinigami-777]

Thanks @alpeb . Added spaces between those end statements.

[alpeb]

Thanks, can you address my comment about naming above? After that, this PR looks fine from my perspective.

[shinigami-777]

Thanks @shinigami-777 , this looks good to me. I'd like however to amend my previous comment on naming: can you rename the setting createNamespaceMetadataJob, given that it's just one job (per extension)? Sorry for the nit picking!

Yes I have renamed the setting createNamespaceMetadataJob from skipNamespaceMetadataJobs in the extensions files.

[alpeb]

Yes I have renamed the setting createNamespaceMetadataJob from skipNamespaceMetadataJobs in the extensions files.

I still see skipNamespaceMetadataJobs in the diff...

[shinigami-777]

I still see skipNamespaceMetadataJobs in the diff...

I can't see the skipNamespaceMetadataJobs in the changed files. Can you please point me to where it is.

[alpeb]

I meant to say the setting should be createNamespaceMetadataJob instead of createNamespaceMetadataJobs.

[shinigami-777]

I meant to say the setting should be createNamespaceMetadataJob instead of createNamespaceMetadataJobs.

Yes I have updated it to createNamespaceMetadataJob from createNamespaceMetadataJobs.

[alpeb]

Thanks @shinigami-777 , this looks good to me!

[shinigami-777]

Thanks @shinigami-777 , this looks good to me!

Thanks @alpeb for the guidance.