policy: add externalWorkloadSelector to Server resource #11899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
force-pushed
the
zd/add-external-workload-selector
branch
from
9c77387
to
a0654ec
Compare
adleong
approved these changes
Jan 8, 2024
| @@ -72,7 +72,9 @@ spec: | |||
| default: unknown | |||
| - name: v1beta1 | |||
| served: true | |||
| storage: true | |||
| storage: false | |||
| deprecated: true | |||
There was a problem hiding this comment.
what are the consequences of deprecating this? will this produce a flood of warning messages in the policy controller when the CRD is upgraded (before the control plane is upgraded)?
There was a problem hiding this comment.
I have tried that. Did an upgrade of the CRDS only and did not notice any deprecation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for a
Serverresource to select overExternalWorkloadresources in addition to
Pods. For the time being, only one of these selector typescan be specified. This has been realized via incrementing the version of the resource
to
v1beta2Signed-off-by: Zahari Dichev zaharidichev@gmail.com