Add additionalEnv helm settings
#12080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `additionalEnv` helm settings to the proxy and controller manifests alongside the existing `experimentalEnv` ones.
olix0r
reviewed
Feb 15, 2024
Comment on lines
+211
to
+219
| {{- if or (.Values.destinationController).additionalEnv (.Values.destinationController).experimentalEnv }} | ||
| env: | ||
| {{- with (.Values.destinationController).additionalEnv }} | ||
| {{- toYaml . | nindent 8 -}} | ||
| {{- end }} | ||
| {{- with (.Values.destinationController).experimentalEnv }} | ||
| {{- toYaml . | nindent 8 -}} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
tioli, I think we could minimize this with something like
{{- with .Values.destinationController | concat .experimentalEnv .additionalEnv }}
I haven't tested this specific syntax but the general idea should avoid duplication. Here and throughout. Furthermore, we could consider using a partial here to reduce boilerplate
There was a problem hiding this comment.
It appears with cannot be used in a pipe. So we have to replicate .Values.destinationController on the right. And concat will error if one of its args is nil, so we have to pipe to default list "" both vars. So the one liner ends up being not pretty.
adleong
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
additionalEnvhelm settings to the proxy and controller manifests alongside the existingexperimentalEnvones.