fix: change log level when err is http.ErrServerClosed
#12167
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ListenAndServe always returns a non-nil error. If error is http.ErrServerClosed, server is not failed to start. So log level sholud be Info not Error if error is http.ErrServerClosed. Signed-off-by: wafuwafu13 <jaruwafu@gmail.com>
Signed-off-by: wafuwafu13 <jaruwafu@gmail.com>
alpeb
reviewed
Feb 29, 2024
mateiidavid
reviewed
Mar 1, 2024
|
@wafuwafu13 do you mind pulling in the latest main into your branch? That should fix the |
|
@mateiidavid |
Signed-off-by: wafuwafu13 <jaruwafu@gmail.com>
wafuwafu13
force-pushed
the
change-log-level
branch
from
d4aac8a
to
75b24a2
Compare
mateiidavid
reviewed
Mar 13, 2024
mateiidavid
reviewed
Mar 13, 2024
| @@ -1,8 +1,10 @@ | |||
| package destination | |||
|
|
|||
| import ( | |||
| "errors" | |||
There was a problem hiding this comment.
Hmm, for some reason this got picked up even though it's not part of this change. Do you mind pulling latest main again?
git pull <upstream> main
should do the trick. If it doesn't, you can perhaps do a soft reset and checkout the file.
Signed-off-by: wafuwafu13 <jaruwafu@gmail.com>
Signed-off-by: wafuwafu13 <jaruwafu@gmail.com>
mateiidavid
approved these changes
Mar 18, 2024
olix0r
approved these changes
Mar 22, 2024
olix0r
reviewed
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListenAndServe always returns a non-nil error.
If error is
http.ErrServerClosed, server is not failed to start.So log level sholud be Info not Error if error is
http.ErrServerClosed.