Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct resources attribute values for repair-controller #12180

Merged

Conversation

relu
Copy link
Contributor

@relu relu commented Feb 29, 2024

The repair-controller was incorrectly configured to use the same resources attribute values as the install-cni container even though it defines its own under repairController.

@relu relu requested a review from a team as a code owner February 29, 2024 09:15
The repair-controller was incorrectly configured to use the same resources attribute values as the install-cni container even though it defines its own under `repairController`.

Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
@alpeb alpeb force-pushed the fix-cni-repair-controller-resources-ref branch from 65df1a9 to 013c91a Compare February 29, 2024 19:25
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @relu , this looks good to me. I rebased against main to pick up a fix that addressed some test flakiness.

Copy link
Member

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mateiidavid mateiidavid merged commit 0f68655 into linkerd:main Mar 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants