identity: tweak token validation log levels #12187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateiidavid
reviewed
Mar 1, 2024
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
force-pushed
the
zd/tweak-token-validation-log-level
branch
from
30293f5
to
d609bad
Compare
mateiidavid
approved these changes
Mar 1, 2024
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
alpeb
approved these changes
Mar 4, 2024
GrigoriyMikhalkin
pushed a commit
to GrigoriyMikhalkin/linkerd2
that referenced
this pull request
Mar 10, 2024
Currently, when an invalid token has been provided by the proxy to the destination's `Certify` method, the error is logged at the debug level. We change that to INFO to make it more visible. Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an invalid token has been provided by the proxy to the destination's
Certifymethod, the error is logged at debug level. We ideally want to make that more visible, hence changing to info.Signed-off-by: Zahari Dichev zaharidichev@gmail.com