Removes should not change local traffic policy #12325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
reviewed
Mar 21, 2024
olix0r
approved these changes
Mar 21, 2024
|
Thanks. This looks great! I will close mine. Can we get it back port to 2.15 and 2.14 if possible? |
yc185050
approved these changes
Mar 22, 2024
|
@yc185050 we are not planning a 2.14 backport at this point, but i think this is a good candidate for a 2.15 backport. |
alpeb
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12311
When the endpoint translator receives a
removecall, it was updating it's local traffic policy based on the address set passed to remove. However, sinceremoveis only meant to remove addresses and not change the address metadata, the endpoints watcher was not setting local traffic policy on these calls toremove. This can result in calls toremovetemporarily turning off local traffic policy which will cause non-local addresses to be sent to clients.Since
removeshould not change address metadata, we now disregard any metadata in the call toremove, including any changes to the local traffic policy.