fix panic in service mirror controller #12406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
reviewed
Apr 8, 2024
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
approved these changes
Apr 10, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
If the service mirror controller encounters an error listing mirror services during endpoints repair, this error is logged but processing continues. This causes a nil pointer dereference which results in a panic. Instead, we abort the endpoints repair with a retryable error so that the repair endpoints event is re-enqueued and the panic is avoided. Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the service mirror controller encounters an error listing mirror services during endpoints repair, this error is logged but processing continues. This causes a nil pointer dereference which results in a panic.
Instead, we abort the endpoints repair with a retryable error so that the repair endpoints event is re-enqueued and the panic is avoided.