Fix issues with native sidecars #12453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adleong
reviewed
Apr 18, 2024
alpeb
force-pushed
the
alpeb/native-sidecar-fixups
branch
from
5f196b4
to
a8ebe76
Compare
adleong
approved these changes
Apr 26, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 27, 2024
Closes linkerd#12395 Failing to iterate over init containers as well as regular containers for finding the proxy in various parts of the code when the proxy is injected as a native sidecar resulted in: - `Get` Destination API failing in the presence of opaque ports - Failure having the injector detecting already injected pods - Various CLI issues This PR is split into the following commits addressing each issue separately: a8ebe76 - Fix injection check for existing sidecars 44e9625 - Fix 'linkerd uninject' 6269496 - Fix 'linkerd version --proxy' 42dbdad - Fix 'linkerd identity' 39db823 - Fix 'linkerd check' 7359f37 - Fix 'linkerd dg proxy-metrics' f8f73c4 - Fix destination controller Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 29, 2024
Closes linkerd#12395 Failing to iterate over init containers as well as regular containers for finding the proxy in various parts of the code when the proxy is injected as a native sidecar resulted in: - `Get` Destination API failing in the presence of opaque ports - Failure having the injector detecting already injected pods - Various CLI issues This PR is split into the following commits addressing each issue separately: a8ebe76 - Fix injection check for existing sidecars 44e9625 - Fix 'linkerd uninject' 6269496 - Fix 'linkerd version --proxy' 42dbdad - Fix 'linkerd identity' 39db823 - Fix 'linkerd check' 7359f37 - Fix 'linkerd dg proxy-metrics' f8f73c4 - Fix destination controller Signed-off-by: Mark S <the@wondersmith.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12395
Failing to iterate over init containers as well as regular containers for finding the proxy in various parts of the code when the proxy is injected as a native sidecar resulted in:
GetDestination API failing in the presence of opaque portsThis PR is split into the following commits addressing each issue separately:
a8ebe76 - Fix injection check for existing sidecars
44e9625 - Fix 'linkerd uninject'
6269496 - Fix 'linkerd version --proxy'
42dbdad - Fix 'linkerd identity'
39db823 - Fix 'linkerd check'
7359f37 - Fix 'linkerd dg proxy-metrics'
f8f73c4 - Fix destination controller