Restore Server v1beta1 Go API definition #12529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `v1beta1` Go API definition for Servers was removed in linkerd#11920, in favor of the `v1beta2` definition that was being added. For backwards compatability, the `v1beta1` definition should have been left in place. Signed-off-by: Kevin Ingelman <ki@buoyant.io>
I've run `bin/update-codegen.sh` with the old Server `v1beta1` Go API definition restored, to generate updating bindings. Signed-off-by: Kevin Ingelman <ki@buoyant.io>
In v1beta2, the Server CRD supports setting either `podSelector` or `externalWorkloadSelector`, but not both. Therefore we should tag both fields with `omitempty` for the purpose of serialization. Signed-off-by: Kevin Ingelman <ki@buoyant.io>
adleong
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
v1beta1Go API definition for Servers was removed in #11920, in favor of thev1beta2definition that was being added. For backwards compatibility, thev1beta1definition should have been left in place.I've split this change into two commits:
controller/gen/apis/server/v1beta1bin/update-codegen.shwith the v1beta1 definition in place