Remove stream concurrency limits #12598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our gRPC servers use the default gRPC server configuration, which limits the number of concurrent streams to 100. Since the controllers run with proxies, this provides a hard scaling limit for the number of watches an application can have. This change updates our gRPC server configuration to clear the default concurrency limit, allowing the server to handle as many streams as possible.
By default, Go gRPC servers are configured with `max_concurrent_streams=100`. The server option can potentially be a bottleneck, in particular for the destination service, when more than 100 streams are initiated concurrently by clients. This change removes the bound by setting the option to 0 explicitly. Signed-off-by: Matei David <matei@buoyant.io>
olix0r
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our gRPC servers use the default gRPC server configuration, which
limits the number of concurrent streams to 100. Since the controllers
run with proxies, this provides a hard scaling limit for the number of
watches an application can have.
This change updates our gRPC server configuration to clear the default
concurrency limit, allowing the server to handle as many streams as
possible.