Make IPv6 support opt-in in linkerd-cni #12663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to 7dbafb2 where we made IPv6 support opt-in for the control plane and proxy init. This follows suit doing the same for linkerd-cni.
alpeb
added a commit
to linkerd/linkerd2-proxy-init
that referenced
this pull request
May 30, 2024
Ignoring these failures can cause IPv6 traffic to bypass the proxy; i.e. IPv6 traffic can work in a cluster but linkerd might not be configured with the appropriate iptables flavor (nft or legacy) and so the rules won't be set. Back when we had IPv6 support enabled by default we still ran these ip6tables rules in IPv4-only clusters and so ignored failures to avoid breaking things unexpectedly. But now that IPv6 support is opt-in, we should expect the cluster to provide a fully functional IPv6 stack and linkerd is configured appropriately for it, and so fail early when things don't work as expected. This change also explicitly disables IPv6 in the integration tests. Note that tests won't pass until linkerd/linkerd2#12663 gets included into an edge.
adleong
approved these changes
May 30, 2024
mateiidavid
approved these changes
May 31, 2024
alpeb
added a commit
to linkerd/linkerd2-proxy-init
that referenced
this pull request
May 31, 2024
Ignoring these failures can cause IPv6 traffic to bypass the proxy; i.e. IPv6 traffic can work in a cluster but linkerd might not be configured with the appropriate iptables flavor (nft or legacy) and so the rules won't be set. Back when we had IPv6 support enabled by default we still ran these ip6tables rules in IPv4-only clusters and so ignored failures to avoid breaking things unexpectedly. But now that IPv6 support is opt-in, we should expect the cluster to provide a fully functional IPv6 stack and linkerd is configured appropriately for it, and so fail early when things don't work as expected. This change also explicitly disables IPv6 in the integration tests. Note that tests won't pass until linkerd/linkerd2#12663 gets included into an edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to 7dbafb2 where we made IPv6 support opt-in for the control plane and proxy init. This follows suit doing the same for linkerd-cni.