Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle httproute grpcroute conflicts #12782

Merged
merged 1 commit into from
Jun 28, 2024
Merged

handle httproute grpcroute conflicts #12782

merged 1 commit into from
Jun 28, 2024

Conversation

adleong
Copy link
Member

@adleong adleong commented Jun 26, 2024

GEP-1426 specifies that if a GrpcRoute and an HttpRoute both attempt to attach to the same parent, the HttpRoute should be ignored and have the Accepted condition set to false with the reason RouteReasonConflicted.
https://gateway-api.sigs.k8s.io/geps/gep-1426/#route-types

We update the status controller and outbound policy index to implement this behavior.

Signed-off-by: Alex Leong <alex@buoyant.io>
@adleong adleong requested a review from a team as a code owner June 26, 2024 19:33
@adleong adleong merged commit 4a07961 into main Jun 28, 2024
27 checks passed
@adleong adleong deleted the alex/http-grpc-conflict branch June 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants