Add prefixes to "partials" and "patch" Helm charts (#3392) #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIVagant
force-pushed
the
kivagant/charts_prefixes
branch
7 times, most recently
from
b9d88f2
to
929cb5e
Compare
|
Please help me to test this. |
KIVagant
force-pushed
the
kivagant/charts_prefixes
branch
from
929cb5e
to
1ba6944
Compare
Fixes linkerd#3392 Changes chart names so that they can be pushed in any Helm chart repository without name collisions. Signed-off-by: Eugene Glotov <kivagant@gmail.com>
KIVagant
force-pushed
the
kivagant/charts_prefixes
branch
from
1ba6944
to
263405d
Compare
|
Feel free to close this if #3365 fixes the problem globally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3392
Changes chart names so that they can be pushed in any Helm chart repository without name collisions.
Signed-off-by: Eugene Glotov kivagant@gmail.com