New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint all markdown files in CI #4402
Conversation
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
This depends on #4403 which applies all the lints that this will error on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should we have a .prettierrc
in here to do the formatting by default for folks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to run markdown linting locally? How do I know if I've violated a lint rule before running through CI?
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
@adleong I answered this here. I added a Using |
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…n-lints-ci Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
## Motivation Necessary lints for #4402 Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
…n-lints-ci Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Motivation
linkerd/rfc#22
Solution
Use the markdown-lint-action to lint all
.md
files for all pull requestsand pushes to master.
This action uses the default rules outlined in markdownlint
package.
The additional rules are added are explained below:
Significant headers in
CHANGES.md
as long as they are part of separaterelease headers)
Signed-off-by: Kevin Leimkuhler kevin@kleimkuhler.com