Integration test for proxy-injector reinvocation #6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary for #3750 and #6267 This uses a generic [kubemod](https://github.com/kubemod/kubemod), a generic mutating webhook, in a new integration test to prove that the proxy-injector is ignoring changes made by webhooks run after it. Once we implement reinvocation for the injector, this test should also be changed to reflect that.
kleimkuhler
approved these changes
Jun 19, 2021
Co-authored-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Co-authored-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
alpeb
added a commit
that referenced
this pull request
Jun 22, 2021
Fixes #3750 and partially #6267 As of k8s 1.15 mutating webhooks can be reinvoked whenever another mutating webhook running after the current one mutates the pod being persisted. Enabling reinvocation for the injector will allow configuring the proxy with annotations generated by such other mutating webhooks. The implementation consists on adding "remove" statements into the json patch returned by the injector, implemented mostly in the new file `pkg/inject/pod_patch.go` which now holds the `podPatch`, moved from `pkg/inject/inject.go`. This also updates the "reinvocation" integration test introduced in #6309 to properly verify the reinvocation is happening. And this also means the "existing proxy sidecar" check is no longer relevant, and has been limited to "existing 3rd party sidecar". Possible followup: refactor the CLI inject and uninject commands to properly leverage the cleanup done by this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary for #3750 and #6267
This uses kubemod, a generic mutating webhook, in a new integration test to prove that the proxy-injector is ignoring changes made by webhooks that run after it.
Once we implement reinvocation for the injector, this test should also be changed to reflect that.