-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the policy-controller release build process #6672
Merged
Merged
Commits on Aug 11, 2021
-
policy-controller: Update kube, k8s-openapi dependencies
kube v0.59 depends on k8s-openapi v0.13, which includes breaking changes. This change updates these dependencies and modifies our code to account for these changes. Furthermore, we now use the k8s-openapi feature `v1_16` so that we use an API version that is compatible with Linkerd's minimum support kubernetes version. Closes #6657 #6658 #6659
Configuration menu - View commit details
-
Copy full SHA for 422ef7a - Browse repository at this point
Copy the full SHA 422ef7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c28f0e - Browse repository at this point
Copy the full SHA 5c28f0eView commit details
Commits on Aug 12, 2021
-
release: Use a temporary file-system for docker builds
The policy-controller fails to build on arm32 due to a file system error. crazy-max/ghaction-docker-buildx#172 describes a workaround: create a smaller temporary filesystem for docker builds. This change employs this workaround to unblock releasing linkerd.
Configuration menu - View commit details
-
Copy full SHA for 6f3f486 - Browse repository at this point
Copy the full SHA 6f3f486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04df5bc - Browse repository at this point
Copy the full SHA 04df5bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b13e516 - Browse repository at this point
Copy the full SHA b13e516View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcafc31 - Browse repository at this point
Copy the full SHA fcafc31View commit details
Commits on Aug 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ed8bb52 - Browse repository at this point
Copy the full SHA ed8bb52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dab63c - Browse repository at this point
Copy the full SHA 7dab63cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4357884 - Browse repository at this point
Copy the full SHA 4357884View commit details -
Configuration menu - View commit details
-
Copy full SHA for 163503b - Browse repository at this point
Copy the full SHA 163503bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c61485 - Browse repository at this point
Copy the full SHA 8c61485View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4682194 - Browse repository at this point
Copy the full SHA 4682194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86f297a - Browse repository at this point
Copy the full SHA 86f297aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59ba51a - Browse repository at this point
Copy the full SHA 59ba51aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a96a88e - Browse repository at this point
Copy the full SHA a96a88eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb7ba71 - Browse repository at this point
Copy the full SHA fb7ba71View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8a2d91 - Browse repository at this point
Copy the full SHA c8a2d91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c76905 - Browse repository at this point
Copy the full SHA 3c76905View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97deb73 - Browse repository at this point
Copy the full SHA 97deb73View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4156dc - Browse repository at this point
Copy the full SHA a4156dcView commit details -
Update the policy-controller release build process
We can't use the typical multiarch docker build with the proxy: qemu-hosted arm64/arm builds take 45+ minutes before failing due to missing tooling--specifically `protoc`. (While there is a `protoc` binary available for arm64, there are no binaries available for 32-bit arm hosts). To fix this, this change updates the release process to cross-build the policy-controller on an amd64 host to the target architecture. We separate the policy-controller's dockerfiles as `amd64.dockerfile`, `arm64.dockerfile`, and `arm.dockerfile`. Then, in CI we build and push each of these images individually (in parallel, via a build matrix). Once all of these are complete, we use the `docker manifest` CLI tools to unify these images into a single multi-arch manifest. This cross-building approach requires that we move from using `native-tls` to `rustls`, as we cannot build against the platform- appropriate native TLS libraries. The policy-controller is now feature- flagged to use `rustls` by default, though it may be necessary to use `native-tls` in local development, as `rustls` cannot validate TLS connections that target IP addresses. The policy-controller has also been updated to pull in `tracing-log` for compatibility crates that do not use `tracing` natively. This was helpful while debugging connectivity issue with the Kubernetes cluster. The `bin/docker-build-policy-controller` helper script now *only* builds the amd64 variant of the policy controller. It fails when asked to build multiarch images.
Configuration menu - View commit details
-
Copy full SHA for 6d41aff - Browse repository at this point
Copy the full SHA 6d41affView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22d4e5e - Browse repository at this point
Copy the full SHA 22d4e5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f83a1c - Browse repository at this point
Copy the full SHA 3f83a1cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.