Update babel to use env and react-app as presets.
#976
Conversation
grampelberg
force-pushed
the
grampelberg/babel-updates
branch
from
01a2196
to
6090cc0
Compare
bin/web
Outdated
|
|
||
| DEV_PORT=8080 | ||
| export NODE_ENV=${NODE_ENV:=development} | ||
| PUBLIC_API_SOURCE=k8s |
There was a problem hiding this comment.
I don't see the PUBLIC_API_SOURCE var used anywhere. Maybe remove it?
bin/web
Outdated
| function err { local x=$? ; msg "$*" ; return $(( $x == 0 ? 1 : $x )) ;} | ||
| function out { printf '%s\n' "$*" ;} | ||
|
|
||
| if [[ ${1:-} ]] && declare -F | cut -d' ' -f3 | fgrep -qx -- "${1:-}" |
There was a problem hiding this comment.
I prefer grep -F here, since fgrep may not be present on some systems.
bin/web
Outdated
| esac | ||
| done | ||
|
|
||
| nc -z localhost 8085 || port-forward & |
There was a problem hiding this comment.
This is super handy for the dev target. I think it would also be useful to add it to the run target below.
web/Dockerfile
Outdated
| # node dependencies | ||
| RUN $HOME/.yarn/bin/yarn install --pure-lockfile | ||
| RUN $ROOT/bin/web setup --pure-lockfile | ||
| RUN ls $PACKAGEDIR/node_modules | grep babel |
There was a problem hiding this comment.
This looks like a stray debug RUN command. Maybe we should remove it?
| @@ -60,9 +60,9 @@ jobs: | |||
| - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.3.2 | |||
| - export PATH="$HOME/.yarn/bin:$PATH" | |||
| install: | |||
| - cd web/app && yarn && yarn webpack | |||
| - ./bin/web build | |||
There was a problem hiding this comment.
As far as I can tell, the CI failure happening on this branch stems from the fact that we're no longer running yarn without any arguments -- we're just running yarn webpack, which is failing. I think you can fix this with:
install:
- ./bin/web setup
- ./bin/web build
6090cc0
to
4f21c5e
Compare
|
@klingerf ahhhha! Thank you! Should be all updated now (and it looks like the tests are passing again). |
web/app/package.json
Outdated
| "babel-preset-es2015": "^6.24.1", | ||
| "babel-plugin-syntax-object-rest-spread": "^6.13.0", | ||
| "babel-plugin-transform-object-rest-spread": "^6.26.0", | ||
| "babel-preset-env": "^1.7.0", | ||
| "babel-preset-react": "^6.24.1", |
There was a problem hiding this comment.
Should we remove the "babel-preset-react" dev dependency now that we're no longer using the "react" preset in .babelrc?
There was a problem hiding this comment.
I can strip these down quite a bit more actually ....
- Switched from `es2015` to `env` for the default preset. This is the recommended preset and allows us to track the latest and greatest moving forward. - Added `react-app` as a preset. We get class properties (and thus => for context) as well as the current recommended settings for react apps. - Created a `web` script that provides functions for common tasks. `react-app` requires that BABEL_ENV/NODE_ENV is set and this guarantees it. - Updated the web dockerfile to set NODE_ENV correctly and use `bin/web`. - Moved the babel related modules over to devDependencies.
grampelberg
force-pushed
the
grampelberg/babel-updates
branch
from
4f21c5e
to
0713bf0
Compare
es2015toenvfor the default preset. This is the recommended preset and allows us to track the latest and greatest moving forward.react-appas a preset. We get class properties (and thus => for context) as well as the current recommended settings for react apps.webscript that provides functions for common tasks.react-apprequires that BABEL_ENV/NODE_ENV is set and this guarantees it.bin/web.