-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop special-casing conduit controller in Grafana #984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I just had one comment about the datasource for the new dashboard.
"bars": false, | ||
"dashLength": 10, | ||
"dashes": false, | ||
"datasource": "${DS_PROMETHEUS}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️ Great, thanks for updating.
The Grafana dashboards were explicitly filtering out Conduit control-plane data. Remove control-plane filtering from Grafana dashboards. This brings Grafana in-line with web, and also encourages better dog-fooding of our proxy metrics and dashboards. Also update Grafana to 5.1.3, update the BUILD.md architecture diagram to include Promethues and Grafana, and introduce a Prometheus Benchmark dashboard, courtesy of Robust Perception. Fixes #908 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
7037b9c
to
4838c24
Compare
The Grafana dashboards were explicitly filtering out Conduit
control-plane data.
Remove control-plane filtering from Grafana dashboards. This brings
Grafana in-line with web, and also encourages better dog-fooding of our
proxy metrics and dashboards. Also update Grafana to 5.1.3, update the
BUILD.md architecture diagram to include Promethues and Grafana, and
introduce a Prometheus Benchmark dashboard, courtesy of Robust
Perception.
Fixes #908
Signed-off-by: Andrew Seigner siggy@buoyant.io