Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkerd-viz: Update grafana setting when using 2.12.x #1568

Open
hungran opened this issue Feb 6, 2023 · 1 comment
Open

Linkerd-viz: Update grafana setting when using 2.12.x #1568

hungran opened this issue Feb 6, 2023 · 1 comment

Comments

@hungran
Copy link

hungran commented Feb 6, 2023

https://github.com/linkerd/website/blob/main/linkerd.io/content/2.12/tasks/grafana.md?plain=1#L53-L74
The setting for grafana should be

grafana.ini:
  server:
    root_url: '%(protocol)s://%(domain)s:%(http_port)s/grafana/'
    serve_from_sub_path: true

otherwise if not using port

grafana.ini:
  server:
    root_url: '%(protocol)s://%(domain)s:/grafana/'
    serve_from_sub_path: true

so the grafana.url should be below

linkerd viz install --set grafana.url=grafana.grafana \
  | kubectl apply -f -

doesn't need port

@PaarthAgarwal
Copy link

I'd like to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants