Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply @karr9's PR #1791 work #1796

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Reapply @karr9's PR #1791 work #1796

merged 1 commit into from
Jun 27, 2024

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Jun 27, 2024

This is the work to highlight Kasper as an Ambassador Emeritus...

  • styles and code are added to highlight an ambassador

Signed-off-by: Karina Rodriguez karina.rodriguez11@gmail.com

  • A new property was added to highlight an ambassador

Signed-off-by: Karina Rodriguez karina.rodriguez11@gmail.com


Signed-off-by: Karina Rodriguez karina.rodriguez11@gmail.com
Co-authored-by: Karina Rodriguez karina.rodriguez11@gmail.com
Co-authored-by: Flynn kflynn@users.noreply.github.com
(cherry picked from commit 55bc952)

* styles and code are added to highlight an ambassador

Signed-off-by: Karina Rodriguez <karina.rodriguez11@gmail.com>

* A new property was added to highlight an ambassador

Signed-off-by: Karina Rodriguez <karina.rodriguez11@gmail.com>

---------

Signed-off-by: Karina Rodriguez <karina.rodriguez11@gmail.com>
Co-authored-by: Karina Rodriguez <karina.rodriguez11@gmail.com>
Co-authored-by: Flynn <kflynn@users.noreply.github.com>
(cherry picked from commit 55bc952)
@kflynn
Copy link
Member Author

kflynn commented Jun 27, 2024

@travisbeckham, we backed this out because of a weird issue when we published -- some folks in some parts of the world were seeing CSS not loading correctly. I don't think this PR actually had anything to do with it, but if you want to stare at the CSS and confirm that it must've been a coincidental CloudFlare flareup (😇), I'd appreciate it! 🙂

Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any CSS issues that would cause it to fail to load, and it's building fine for me locally.

In the past, I have experience caching issues in Cloudflare, that caused similar problems.

@kflynn
Copy link
Member Author

kflynn commented Jun 27, 2024

Thanks! 🙂

@kflynn kflynn merged commit d92417e into main Jun 27, 2024
7 checks passed
@kflynn kflynn deleted the flynn/dev/emeritus branch June 27, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants