Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy-configuration page description clipping fix #752

Merged
merged 2 commits into from Jun 24, 2020

Conversation

tbrockman
Copy link

Image depicting issue (Chrome):
linkerd_before

Image depicting layout after fix (Chrome):
linkerd_after

Allow annotation to wrap, preventing description from clipping on longer annotations. Also makes the page more readable at half-width.

Signed-off-by: Theodore Brockman tbrockma@ualberta.ca

…ger annotations.

Signed-off-by: Theodore Brockman <tbrockma@ualberta.ca>
Copy link
Contributor

@cpretzer cpretzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the attention to detail @tbrockman

I'd be willing to bet that the text-nowrap class was added to make the annotations be all on one line, but I think that's well understood and this change makes the page readable.

@tbrockman
Copy link
Author

No problem @cpretzer !

Yeah, that was my assumption as well, and it's possible this is just a result of longer annotations being added over time, but in any case this seemed like a fine compromise to make for the sake of readability. An alternate layout could also be attempted to accommodate both (maybe something using just horizontal rows) but the table presentation seems pretty natural to me.

Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

PS the CI failure is caused by some dead links in older blog posts. I will fix that in a separate PR.

@ihcsim ihcsim merged commit 8559e9e into linkerd:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants